CA-283754: ppxified interfaces, do not discard internal errors #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseri
changed the title
|
Note:
|
|
I had not realised how much stuff was changed by ocp-indent. I'll separate the commits |
added 5 commits
February 19, 2018 15:35
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
lindig
reviewed
Feb 19, 2018
gpumon/gpumon_interface.ml
Outdated
| let gpu_err = GpuErrors.error | ||
| let gpu_err = Error.{ | ||
| def = gpu_errors; | ||
| raiser = (function | e -> raise (Gpumon_error e)); |
There was a problem hiding this comment.
Here fun e -> raise (Gpumon_error e) would be more natural as we don't have several patterns.
There was a problem hiding this comment.
Indeed, I went with copy-paste. I'll add fixup commits
memory/memory_interface.ml
Outdated
| matcher = function | MemoryError e -> Some e | _ -> None | ||
| } | ||
| def = errors; | ||
| raiser = (function | e -> raise (MemoryError e)); |
There was a problem hiding this comment.
Same as above. But not a real issue.
|
Clusterd is implemented using Lwt, and it already does an |
mcintyre94
pushed a commit
to mcintyre94/xen-api
that referenced
this pull request
Feb 23, 2018
This depends upon xapi-project/xcp-idl#204 being merged Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is updating
memory,gpumonandv6, recently ported to the new ppx interface.This is not updatding
clusterdthat uses a slightly different error reporting and may noot need it (ping @edwintorok).Signed-off-by: Marcello Seri marcello.seri@citrix.com