Port sriov interface to ppx #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Qian <yang.qian@citrix.com>
mseri
reviewed
Mar 8, 2018
| @@ -6,7 +6,7 @@ type address = { | |||
| dev: int; | |||
| fn: int; | |||
| } | |||
| [@@deriving sexp, rpc] | |||
| [@@deriving sexp, rpc, rpcty] | |||
There was a problem hiding this comment.
Do we use rpc? Can we just use rpcty instead, as done in other modules or itwill break lots of other code?
There was a problem hiding this comment.
I think that this is shared with the xenops_interface, which is still on camlp4.
There was a problem hiding this comment.
Non of the three things above is related to camlp4 though. I am expecting that removing rpc fails something, but I think it's worth double checking and see if we can reduce the autogenerated stuff if not needed
There was a problem hiding this comment.
Without it, xcpi-idl fails to build:
File "xen/xenops_types.ml", line 19, characters 2-224:
Error: Unbound value rpc_of_address
Hint: Did you mean typ_of_address?
make: *** [Makefile:7: release] Error 1
| let make_vf_config = | ||
| let pci_address_p = Param.mk ~description:["pci address"] Xcp_pci.address in | ||
| let vf_info_p = Param.mk ~description:["vf info"] sriov_pci_t in | ||
| let result_t = Param.mk ~description:["SR-IOV make vf configuration result"] config_result in |
There was a problem hiding this comment.
Why not result_p in line with all the other declarations?
robhoes
approved these changes
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for after rebase master then changes the interface to PPX.
Signed-off-by: Yang Qian yang.qian@citrix.com