CA-194089: allow no-op VM.set_has_vendor_device #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The other approach would have been to require every client to compare the old and new values and only make the API call if they differ. |
In Xapi_vm.assert_can_set_has_vendor_device, we were raising an exception if the PV drivers were in use. Now we do this check only if the new value of has_vendor_device is different to the old one. Signed-off-by: Thomas Sanders <thomas.sanders@citrix.com>
thomassa
force-pushed
the
allow-set-vendor-device-unchanged
branch
from
f82cd63
to
b08fd46
Compare
|
|
thomassa
added a commit
that referenced
this pull request
Jan 4, 2016
CA-194089: allow no-op VM.set_has_vendor_device
jonludlam
pushed a commit
to jonludlam/xen-api
that referenced
this pull request
Jan 21, 2016
…evice-unchanged CA-194089: allow no-op VM.set_has_vendor_device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Xapi_vm.assert_can_set_has_vendor_device, we were raising an
exception if the PV drivers were in use. Now we do this check only
if the new value of has_vendor_device is different to the old one.