CA-213568: Restore VM power state on checkpoint failure. #2684
Conversation
Restore VM power state before raising an exception for checkpoint failure. Signed-off-by: Sharad Yadav <sharad.yadav@citrix.com>
|
@xen-git retest this please. |
|
I can't see anywhere in this pull request that does anything with the VM power state. Maybe I'm missing something. Unless I'm missing something obvious, please can you elaborate on how the changes do what you say in the commit message? |
| if not (TaskHelper.is_cancelling ~__context) then begin | ||
| try Some (Xapi_vm_clone.clone Xapi_vm_clone.Disk_op_checkpoint ~__context ~vm ~new_name ~snapshot_info_record:!snapshot_info) |
There was a problem hiding this comment.
As per CA-213568: Call Xapi_vm_clone.clone Xapi_vm_clone.Disk_op_checkpoint ~__context ~vm ~new_name ~snapshot_info_record:!snapshot_info fails with error Server_error(SR_BACKEND_FAILURE_44, [ ; There is insufficient space; ]). This exception is raised before calling subsequent call Xapi_xenops.resume ~__context ~self:vm ~start_paused:false ~force:false. This is causing the VM to be in suspended state during a checkpoint.
There was a problem hiding this comment.
Ah ha! I see now. The call to Xapi_xenops.resume was not in the context of the patch. Only visible when expanding the file.
|
@simonjbeaumont thanks for review, Can we merge this PR If we are happy :) |
Restore VM power state before raising an exception for
checkpoint failure.
Signed-off-by: Sharad Yadav sharad.yadav@citrix.com