Removed obsolete and unnecessary files. #2809
Conversation
|
Note: I still need to review this, but in any case, we cannot put this in the master branch at this point in time. |
|
I have marked this blocked because we cannot merge to trunk-ring3 at the moment. |
|
Over to @robhoes to review :-) |
| install-debian | ||
|
|
||
| [3][ browse ] [4][ download ] | ||
| [install-debian][1] |
There was a problem hiding this comment.
Is this supposed to be markdown? I don't think the syntax is right.
There was a problem hiding this comment.
It's markdown recognisable by github if the file has .md extension - which I've just realised this file does not have, so thanks for pointing it out, I'll rename it.
| 9. file://localhost/bind/myrepos/xen-api/scripts/examples/bash-cli/move-management-to-bond.html | ||
| 10. file://localhost/bind/myrepos/xen-api/scripts/examples/bash-cli/move-management-to-bond | ||
|
|
||
| [1]: install-debian |
There was a problem hiding this comment.
Apologies, I don't understand your question. Are you asking whether this particular example is useful or whether it's useful to have a link to the example in the readme file?
| @@ -1,110 +0,0 @@ | |||
| <html> | |||
There was a problem hiding this comment.
I think that removing this file will break some targets in the ocaml/idl/OMakefile (e.g. noarch-install).
There was a problem hiding this comment.
Also the other html files in ocaml/idl: do they have replacements somewhere? Or is that not needed?
There was a problem hiding this comment.
I believe these files used to be needed for the content on the old community page, but they're out of date and I don't think they're currently published anywhere. In any case I'll have another look to ensure the changes are not breaking anything.
Html for the scipts does not need to be in source control as it can be autogenerated using various tools (e.g. pygmentize, enscript etc; the scripts are even automatically highlighted on github). Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
…rrectly. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The old name sdk-install was giving the impression they were called from the homonymous rule further up the folder hierarchy, while they are actually a prerequisite of noarch-install. Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
But I think it was called from both. I.e. from |
|
It looks to me, however, that the sdk-install make target is completely unused, because it is not referenced by the spec file. |
|
I've removed it. Now you can resume the review, I've updated the label :) |
|
I think all those targets should have been removed when the SDK VM and the community site went, but they were left behind because it was not obvious what was needed for the docs. |
|
Fantastic ✨ |
Html for the scripts does not need to be in source control as it can be
autogenerated using various tools (e.g. pygmentize, enscript etc; the scripts
are even automatically highlighted on github).
Signed-off-by: Konstantina Chremmou konstantina.chremmou@citrix.com