CP-26717: Update Xapi to use PPX-based Gpumon IDL #3418
Conversation
ocaml/xapi/xapi_gpumon.ml
Outdated
| | _::_ -> failwith @@ Printf.sprintf | ||
| "%s: VM %s (dom %d) has more than one NVIDIA vGPU (%s)" | ||
| this (Ref.string_of vm) domid __LOC__ | ||
| |> fun self -> Db.PCI.get_pci_id ~__context ~self |
There was a problem hiding this comment.
Indentation here has gone wild as well... it would be nice to see if there is a flag to stop this behaviour in ocp-indent
There was a problem hiding this comment.
I think it assumes it's part of the same function, which would make sense. Not sure how you'd differentiate between that without parentheses/begin-end
There was a problem hiding this comment.
But what if the code above was like this:
|> (function
| x -> do_this
| y -> some_function
|> followed_by_this_one)
|> something_with_result_of_pattern_match
I'm not sure how it would parse that without the parentheses
There was a problem hiding this comment.
I would expect to use parentheses in that case in fact
There was a problem hiding this comment.
I think that's currently the situation; the original function wasn't wrapped in parentheses, so ocp-indent assumed the next |> function was part of the same lambda function, hence the weird indent. I suppose we could still try to decrease the size, since it doesn't need to be that far in.
There was a problem hiding this comment.
Yes, I'd like to understand if it is right or not :)
ocaml/xapi/xapi_gpumon.ml
Outdated
| @@ -152,7 +151,7 @@ module Nvidia = struct | |||
| let vgpu_metadata () = | |||
| Db.VGPU.get_compatibility_metadata ~__context ~self:vgpu | |||
| |> fun md -> [List.assoc key md] | |||
| |> List.map Stdext.Base64.decode in | |||
| |> List.map Stdext.Base64.decode in | |||
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
This PR is the second of three to port GPU monitoring daemon gpumon to use PPX-based code generation for RPCs.