CA-315107 Create xapi-init-complete systemd target #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robhoes
reviewed
Apr 24, 2019
| @@ -1,7 +1,8 @@ | |||
| [Unit] | |||
| Description=Start/stop domains on dom0 start/shutdown | |||
| Requires=proc-xen.mount | |||
| After=remote-fs.target xapi.service | |||
| Wants=xapi-init-complete.target | |||
| After=remote-fs.target xapi-init-complete.target | |||
There was a problem hiding this comment.
Will this still do the right thing on shutdown, i.e. stop xapi-domains before xapi?
There was a problem hiding this comment.
It doesn't change the shutdown behaviour. Since xapi-domains is started after xapi, it will be shut down before.
Create a xapi-init-complete.target and a xapi-wait-init-complete.service which is wanted by it. The service invokes the existing xapi-wait-init-complete so that it is only done in one place now. The SPEC file will need altering to enable the xapi-wait-init-complete service on installation. xapi-domains.service (and any other service which needs to start after Xapi has completed initialisation) can now declare Wants=xapi-init-complete.target After=xapi-init-complete.target to ensure that Xapi will be done initialising before they are started. Signed-off-by: Tim Smith <tim.smith@citrix.com>
TimSmithCtx
force-pushed
the
private/timsmi/CA-315107
branch
from
c5c0378
to
832659b
Compare
lindig
approved these changes
Apr 24, 2019
robhoes
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a xapi-init-complete.target and a xapi-wait-init-complete.service
which is wanted by it. The service invokes the existing
xapi-wait-init-complete so that it is only done in one place now.
The SPEC file will need altering to enable the xapi-wait-init-complete
service on installation.
xapi-domains.service (and any other service which needs to start after
Xapi has completed initialisation) can now declare
Wants=xapi-init-complete.target
After=xapi-init-complete.target
to ensure that Xapi will be done initialising before they are started.