Choose size of batch VM evacuation #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamreis
force-pushed
the
dynamical-evacuation-batch-size
branch
2 times, most recently
from
b432370
to
dac016c
Compare
psafont
requested changes
Oct 13, 2023
benjamreis
force-pushed
the
dynamical-evacuation-batch-size
branch
3 times, most recently
from
b1dba54
to
7642f01
Compare
minglumlu
reviewed
Oct 16, 2023
ocaml/idl/datamodel_host.ml
Outdated
| ; { | ||
| param_type= Int | ||
| ; param_name= "evacuate_batch_size" | ||
| ; param_doc= "Number of VM to evacuate at the same time" |
There was a problem hiding this comment.
How about The maximum number of VMs to be migrated per batch?
There was a problem hiding this comment.
Right, it's more accurate. thx :)
benjamreis
force-pushed
the
dynamical-evacuation-batch-size
branch
3 times, most recently
from
c9375cd
to
eee67b9
Compare
minglumlu
reviewed
Oct 17, 2023
ocaml/idl/datamodel_host.ml
Outdated
| ; param_name= "evacuate_batch_size" | ||
| ; param_doc= "The maximum number of VMs to be migrated per batch" | ||
| ; param_release= next_release | ||
| ; param_default= None |
There was a problem hiding this comment.
From https://github.com/xapi-project/xen-api/blob/master/ocaml/idl/ocaml_backend/gen_server.ml#L67, I understand is that None means it is a mandatory parameter.
While this should not be as the old clients may send calls without the new parameter. Then Some <N> would be a default value in this case. This could be tested with an old client.
lindig
reviewed
Oct 17, 2023
benjamreis
force-pushed
the
dynamical-evacuation-batch-size
branch
from
eee67b9
to
ecdae7a
Compare
|
Okay so last forced push should take into account all comments, i'll let you close the conversations when satisfied. Meanwhile I tested giving a number and letting the default value take over, both works as expected. :) |
lindig
reviewed
Oct 17, 2023
benjamreis
force-pushed
the
dynamical-evacuation-batch-size
branch
from
ecdae7a
to
d1a220a
Compare
lindig
approved these changes
Oct 17, 2023
New optional argument to `Host.evacuate`: `evacuate_batch_size` When provided uses it instead of `xapi.conf`'s `evacuation_batch_size` When not provided uses the `xapi.conf` option Fixes: xapi-project#5202 Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
benjamreis
force-pushed
the
dynamical-evacuation-batch-size
branch
from
d1a220a
to
3ad1b3a
Compare
psafont
approved these changes
Oct 17, 2023
julien-f
pushed a commit
to vatesfr/xen-orchestra
that referenced
this pull request
Oct 19, 2023
Fixes #7105 See xapi-project/xen-api#5202 See xapi-project/xen-api#5203 `host.evacuate`: try passing optional batch size argument. If not supported: remove it and try again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New optional argument to
Host.evacuate:evacuate_batch_sizeWhen provided uses it instead ofxapi.conf'sevacuation_batch_sizeWhen not provided uses thexapi.confoptionFixes: #5202