xe pif-list default params (#5263)
#5264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run |
robhoes
reviewed
Nov 27, 2023
| @@ -935,7 +935,8 @@ let gen_cmds rpc session_id = | |||
| ; Client.PIF.( | |||
| mk get_all_records_where get_by_uuid pif_record "pif" [] | |||
| [ | |||
| "uuid"; "device"; "VLAN"; "mac"; "network-uuid"; "currently-attached" | |||
| "uuid"; "device"; "VLAN"; "MAC"; "network-uuid"; "currently-attached"; | |||
| "host-id" | |||
There was a problem hiding this comment.
It's host-uuid... and please make sure you test it ;)
There was a problem hiding this comment.
For some reason, xe pif-list still does not output either MAC or host-id here, after integrating this patch into the RPM build chain to be sure not to miss anything.
Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
The wrong case causes the MAC param not to be part of the default display. Signed-off-by: Yann Dirson <yann.dirson@vates.fr>
ydirson
force-pushed
the
xe-pif-list-params
branch
from
e191254
to
4825a17
Compare
robhoes
approved these changes
Nov 27, 2023
psafont
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
host-idtopif-listparams printed by default, and fix the "MAC" case discrepancy noticed by @robhoes