[OIL] Templatization of PS Remove-Xen* cmdlets. Refactoring of HTTP_actions.mustache #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com> # Conflicts: # ocaml/sdk-gen/powershell/gen_powershell_binding.ml
kc284
force-pushed
the
private/konstantin1/sdk-ps
branch
from
24cc4a7
to
4e8200b
Compare
duobei
reviewed
Apr 25, 2024
Comment on lines
100
to
+105
| let cmdlets = | ||
| classes |> List.filter generated |> List.map gen_cmdlets |> List.concat | ||
| in | ||
| List.iter (fun x -> write_file x.filename x.content) cmdlets | ||
| List.iter (fun x -> write_file x.filename x.content) cmdlets ; | ||
|
|
||
| classes |> List.filter generated |> List.iter gen_destructor |
There was a problem hiding this comment.
Suggested change
| let cmdlets = | |
| classes |> List.filter generated |> List.map gen_cmdlets |> List.concat | |
| in | |
| List.iter (fun x -> write_file x.filename x.content) cmdlets | |
| List.iter (fun x -> write_file x.filename x.content) cmdlets ; | |
| classes |> List.filter generated |> List.iter gen_destructor | |
| let classes_filterd = List.filter generated classes in | |
| let cmdlets = | |
| classes_filterd |> List.map gen_cmdlets |> List.concat | |
| in | |
| List.iter (fun x -> write_file x.filename x.content) cmdlets ; | |
| List.iter gen_destructor classes_filterd |
There was a problem hiding this comment.
List.concat_map can be used to generate cmdlets as well
Comment on lines
168
to
+197
| `O | ||
| [ | ||
| ("licence", `String Licence.bsd_two_clause) | ||
| ; ("http_actions", `A (List.map action_json filtered_actions)) | ||
| ( "http_actions" | ||
| , `A | ||
| (List.map | ||
| (fun (name, (meth, uri, _, sdkargs, _, _)) -> | ||
| `O | ||
| [ | ||
| ("name", `String name) | ||
| ; ("isPut", `Bool (meth == Put)) | ||
| ; ("isGet", `Bool (meth == Get)) | ||
| ; ("uri", `String uri) | ||
| ; ( "args" | ||
| , `A | ||
| (List.map | ||
| (fun x -> | ||
| `O | ||
| [ | ||
| ("arg_decl", `String (decl_of_sdkarg x)) | ||
| ; ("arg_use", `String (use_of_sdkarg x)) | ||
| ] | ||
| ) | ||
| sdkargs | ||
| ) | ||
| ) | ||
| ] | ||
| ) | ||
| filtered_actions | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Maybe below is little better:
let of_arg arg =
`O
[
("arg_decl", `String (decl_of_sdkarg arg))
; ("arg_use", `String (use_of_sdkarg arg))
]
let of_action (name, (meth, uri, _, sdkargs, _, _)) =
`O
[
("name", `String name)
; ("isPut", `Bool (meth == Put))
; ("isGet", `Bool (meth == Get))
; ("uri", `String uri)
; ("args", `A (List.map of_arg sdkargs))
]
in
`O [( "http_actions", `A (List.map of_action filtered_actions))]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First installment of PS templatization.