CA-391859: Failed to stop varstord-guard #5578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test done:
|
robhoes
approved these changes
Apr 22, 2024
Yes, I should mention that in the comments to clarify that 😸 |
Vincent-lau
approved these changes
Apr 22, 2024
|
This would be useful for master too |
edwintorok
reviewed
Apr 22, 2024
scripts/xe-toolstack-restart
Outdated
| @@ -30,7 +30,7 @@ if [ $POOLCONF == "master" ]; then MPATHALERT="mpathalert"; else MPATHALERT=""; | |||
| SERVICES="perfmon v6d xenopsd xenopsd-xc xenopsd-xenlight | |||
| xenopsd-simulator xenopsd-libvirt xcp-rrdd-iostat xcp-rrdd-squeezed | |||
| xcp-rrdd-xenpm xcp-rrdd-gpumon xcp-rrdd xcp-networkd squeezed forkexecd | |||
| $MPATHALERT xapi-storage-script xapi-clusterd varstored-guard message-switch" | |||
| $MPATHALERT xapi-storage-script xapi-clusterd message-switch varstored-guard" | |||
There was a problem hiding this comment.
Can we put message-switch to the very beginning? Does message-switch have any dependencies of its own?
There was a problem hiding this comment.
I expect all the toolstack daemons to depend on it, so it should be shut down last
There was a problem hiding this comment.
Yes, let's make that change, and target the master branch.
liulinC
force-pushed
the
private/linl/xs9
branch
2 times, most recently
from
e2f9aa5
to
1e39bb7
Compare
varstord-guard has following configuration in the service file After=message-switch.service syslog.target This means varstored-guard needs to be stopped before message-switch, otherwise, it will hung and finally be killed by systemd during xe-toolstack-restart Move message-switch to the begining of the list to shutdown last as all other daemons depend on it Note: the list order is reversed by `for svc in $SERVICES` Signed-off-by: Lin Liu <lin.liu@citrix.com>
liulinC
force-pushed
the
private/linl/xs9
branch
from
1e39bb7
to
e699b39
Compare
|
git diff Manual test on XS8 and XS9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
varstord-guard has following configuration in the service file
After=message-switch.service syslog.target
This means varstored-guard needs to be stopped before message-switch, otherwise, it will hung and finally be killed by systemd during xe-toolstack-restart