Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA-95060 - If a VM shuts down on a slave when xapi is not running, its disks are not deactivated when xapi starts up again #934

Merged
merged 4 commits into from Dec 7, 2012
Merged

CA-95060 - If a VM shuts down on a slave when xapi is not running, its disks are not deactivated when xapi starts up again #934

merged 4 commits into from Dec 7, 2012

Conversation

johnelse
Copy link
Contributor

@johnelse johnelse commented Dec 5, 2012

Tested by:

  • Start one Vista and two Debian VMs on a slave; shut down the slave's xapi; shut down the VMs; restart xapi on the slave; check the VMs' tapdisks are cleaned up.
  • Same as above, but on a master.
  • Manually testing several concurrent VM starts, shutdowns and migrates.
  • Local SR -> Local SR intrapool storage migration.
  • Quicktest.

@johnelse
CA-95060: Keep trying xenopsd->SMAPI calls until they stop throwing E…
7081381 
…CONNREFUSED.

If xapi is not running, xenopsd should wait indefinitely for it to
return when trying to make SMAPI calls.

Signed-off-by: John Else <john.else@citrix.com>
@johnelse
CA-95060: Move exception No_storage_plugin_for_sr to storage_interfac…
1156e0d 
…e.ml

This makes it easier to catch for SMAPI clients, since it no longer gets
wrapped in a Storage_interface.Internal_error.

Signed-off-by: John Else <john.else@citrix.com>
@johnelse
Whitespace: Xenops_server_xen.Storage.dp_destroy
a1ff6f3 
Signed-off-by: John Else <john.else@citrix.com>
@johnelse
CA-95060: Ignore Storage_interface.No_storage_plugin_for_sr when call…
fef8c5a 
…ing DP.destroy from xenops.

Signed-off-by: John Else <john.else@citrix.com>
@johnelse
Copy link
Contributor Author

johnelse commented Dec 5, 2012

I've now also tried restarting xenopsd on the slave while it is stuck waiting for xapi, and doing an xe-toolstack-restart - the tapdisks are eventually closed in both cases once xapi is running again.

jonludlam pushed a commit that referenced this pull request Dec 7, 2012
Merge pull request #934 from johnelse/ca-95060
912128f 
CA-95060 - If a VM shuts down on a slave when xapi is not running, its disks are not deactivated when xapi starts up again
@jonludlam jonludlam merged commit 912128f into xapi-project:master Dec 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnelse @jonludlam