FFS creates new uuid for VHDs with UUID

[BobBall]

When a VHD has a UUID-like-string as it's name that needs to be used as the UUID in XAPI to match the behaviour of other SRs (e.g. EXT, NFS).

This is breaking OpenStack as we rely on the UUID of the imported VHDs

[BobBall]

This is now the cause of the failure of the CI jobs:
2013-10-11 19:15:55.325 �[01;31mERROR root [�[00;36m-�[01;31m] �[01;35m�[01;31mOriginal exception being dropped: ['Traceback (most recent call last):\n', ' File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1268, in _fetch_vhd_image\n _check_vdi_size(context, session, instance, vdis['root']['uuid'])\n', ' File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1308, in _check_vdi_size\n size = _get_vdi_chain_size(session, vdi_uuid)\n', ' File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1288, in _get_vdi_chain_size\n for vdi_rec in _walk_vdi_chain(session, vdi_uuid):\n', ' File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1794, in _walk_vdi_chain\n vdi_ref = session.call_xenapi("VDI.get_by_uuid", vdi_uuid)\n', ' File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 779, in call_xenapi\n return session.xenapi_request(method, args)\n', ' File "/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 133, in xenapi_request\n result = _parse_result(getattr(self, methodname)(_full_params))\n', ' File "/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 203, in _parse_result\n raise Failure(result['ErrorDescription'])\n', "Failure: ['UUID_INVALID', 'VDI', '2280cda6-8109-4407-8edf-b94d50047ac5']\n"]�[00m
2013-10-11 19:15:55.326 �[01;31mERROR nova.utils [�[01;36mreq-eb01c094-8254-4d82-8abf-48f401f7fd03 �[00;36mdemo demo�[01;31m] �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[01;31mFailed to spawn, rolling back�[00m
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00mTraceback (most recent call last):
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 483, in _spawn
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m name_label)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 153, in inner
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m rv = f(_args, *_kwargs)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/vmops.py", line 347, in create_disks_step
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m disk_image_type, block_device_info=block_device_info)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 535, in get_vdis_for_instance
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m context, session, instance, name_label, image, image_type)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1147, in _create_image
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m image_id, image_type)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1090, in _create_cached_image
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m image_id, image_type)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1167, in _fetch_image
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m vdis = _fetch_vhd_image(context, session, instance, image_id)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1274, in _fetch_vhd_image
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m vdi_ref = session.call_xenapi('VDI.get_by_uuid', vdi_uuid)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/opt/stack/nova/nova/virt/xenapi/driver.py", line 779, in call_xenapi
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m return session.xenapi_request(method, args)
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 133, in xenapi_request
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m result = _parse_result(getattr(self, methodname)(_full_params))
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m File "/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 203, in _parse_result
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m raise Failure(result['ErrorDescription'])
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00mFailure: ['UUID_INVALID', 'VDI', '2280cda6-8109-4407-8edf-b94d50047ac5']
�[01;31m2013-10-11 19:15:55.326 TRACE nova.utils �[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] �[00m

[djs55]

OK, thanks for the heads-up

On Sat, Oct 12, 2013 at 3:16 PM, BobBall notifications@github.com wrote:

This is now the cause of the failure of the CI jobs:
2013-10-11 19:15:55.325 [01;31mERROR root [[00;36m-[01;31m]
[01;35m[01;31mOriginal exception being dropped: ['Traceback (most recent
call last):\n', ' File "/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line
1268, in _fetch_vhd_image\n _check_vdi_size(context, session, instance,
vdis['root']['uuid'])\n', ' File
"/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1308, in _check_vdi_size\n
size = _get_vdi_chain_size(session, vdi_uuid)\n', ' File
"/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1288, in _get_vdi_chain_size\n
for vdi_rec in _walk_vdi_chain(session, vdi_uuid):\n', ' File
"/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1794, in _walk_vdi_chain\n
vdi_ref = session.call_xenapi("VDI.get_by_uuid", vdi_uuid)\n', ' File
"/opt/stack/nova/nova/virt/xenapi/driver.py", line 779, in call_xenapi\n
return session.xenapi_request(method, args)\n', ' File
"/usr/local/lib/python2.7/dist-packages/XenAPI.py ", line 133, in
xenapi_request\n result = _parse_result(getattr(self, methodname)(*full_params))\n',
' File "/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 203, in
parseresult\n raise Failure(result['ErrorDescription'])\n', "Failure:
['UUID_INVALID', 'VDI', '2280cda6-8109-4407-8edf-b94d50047ac5']\n"][00m
2013-10-11 19:15:55.326 [01;31mERROR nova.utils
[[01;36mreq-eb01c094-8254-4d82-8abf-48f401f7fd03 [00;36mdemo demo[01;31m]
[01;35m[instance: 92d94f5c-0ddc-4c10-af6d-508b81b260d1] [01;31mFailed to
spawn, rolling back[00m
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00mTraceback (most recent call last):
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/vmops.py", line 483, in spawn
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m namelabel)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/vmops.py", line 153, in inner
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m rv = f(_args, *_kwargs)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/vmops.py", line 347, in create_disks_step
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m disk_image_type,
block_device_info=block_device_info)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 535, in
get_vdis_for_instance
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m context, session, instance,
name_label, image, image_type)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1147, in create
image
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m image_id, image_type)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1090, in create
cached_image
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m image_id, image_type)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1167, in _fetch_image
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m vdis = _fetch_vhd_image(context,
session, instance, image_id)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/vm_utils.py", line 1274, in fetch
vhd_image
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m vdi_ref =
session.call_xenapi('VDI.get_by_uuid', vdi_uuid)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/opt/stack/nova/nova/virt/xenapi/driver.py", line 779, in call_xenapi
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m return
session.xenapi_request(method, args)
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 133, in
xenapi_request
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m result = _parse_result(getattr(self,
methodname)(*full_params))
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m File
"/usr/local/lib/python2.7/dist-packages/XenAPI.py", line 203, in parse
result
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m raise
Failure(result['ErrorDescription'])
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00mFailure: ['UUID_INVALID', 'VDI',
'2280cda6-8109-4407-8edf-b94d50047ac5']
[01;31m2013-10-11 19:15:55.326 TRACE nova.utils [01;35m[instance:
92d94f5c-0ddc-4c10-af6d-508b81b260d1] [00m

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/243#issuecomment-26198175
.

Dave Scott