Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public access #41

Merged
merged 4 commits into from Jul 19, 2020
Merged

Add public access #41

merged 4 commits into from Jul 19, 2020

Conversation

TeoGoddet
Copy link
Contributor

No description provided.

@xarantolus
Copy link
Owner

xarantolus commented Jul 3, 2020

Hey, I really like the idea and from my testing everything looks good 👍 .

It might be interesting to add a link to /public/list to the login page if it is enabled by passing config.allow_public_view to the different render function calls in tools/auth.ts.

If you want to integrate it, it should be possible to apply the patch using git apply link.patch after extracting this file

@TeoGoddet
Copy link
Contributor Author

Thanks for this great idea :) and the patch ! I applied it.

@xarantolus
Copy link
Owner

It's not yet showing up on github. Maybe the push didn't work?

I think that this is ready for merge after that, also thank you :)

@TeoGoddet
Copy link
Contributor Author

Indeed, sorry
It now ok !

@xarantolus
Copy link
Owner

Thank you so much for your contribution, it's really nice :)

@xarantolus xarantolus merged commit f2ac0a3 into xarantolus:master Jul 19, 2020
@xarantolus xarantolus mentioned this pull request Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants