Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved exception types #169

Merged
merged 3 commits into from Dec 28, 2022
Merged

Improved exception types #169

merged 3 commits into from Dec 28, 2022

Conversation

TomNicholas
Copy link
Collaborator

Makes exception classes more specific by replacing TreeError with InvalidTreeError and NotFoundInTreeError.

  • Closes #xxxx
  • Tests added
  • Passes pre-commit run --all-files
  • New functions/methods are listed in api.rst
  • Changes are summarized in docs/source/whats-new.rst

@TomNicholas TomNicholas added the enhancement New feature or request label Dec 28, 2022
@TomNicholas TomNicholas enabled auto-merge (squash) December 28, 2022 02:01
@TomNicholas TomNicholas merged commit e8feb98 into xarray-contrib:main Dec 28, 2022
flamingbear pushed a commit to flamingbear/rewritten-datatree that referenced this pull request Jan 19, 2024
@TomNicholas
Improved exception types xarray-contrib/datatree#169
3761e3a 
* created more specific tree-related exception types

* listed new exception types in public API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TomNicholas