Allow passing os.PathLike as an alternative to strings to represent node paths #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only reason I haven't merged this is that I can't see what mypy's problem with this is: datatree/mapping.py:245: error: Argument 1 to "from_dict" of "DataTree" has incompatible type "dict[str, Any | None]"; expected "MutableMapping[str | PathLike[Any], Any | DataTree[Any] | None]" [arg-type]
Found 1 error in 1 file (checked 25 source files) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadens the types that getitem and setitem methods accept to include anything that follows the
os.PathLikeprotocol.It's possible there are some additional edge cases here that we should forbid, such as passing a Windows-style path.
pre-commit run --all-filesNew functions/methods are listed inapi.rstdocs/source/whats-new.rst