make sure re-quantifying dimension coordinates works #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only changes behavior for dimension coordinates (previously it would have been possible to overwrite the units).
|
I'll merge this now and add a PR to close #47 this week-end |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we use
call_on_datasetthe call does not fail because ofxarray, but because we pass aUnitobject toparse_units. This PR fixes that and adds tests to make sure it stays that way.I also tightened the restriction on dimension coordinates, as it was possible to change their units by re-quantifying. For #47 we might want to partially lift this restriction again.
pre-commit run --all-fileswhats-new.rst