Convert all data variables in a Dataset to the same unit. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keewis
reviewed
Feb 12, 2021
There was a problem hiding this comment.
thanks for the PR, @mikapfl, this looks mostly good to me.
Could you also update the changelog? We currently don't credit the authors, but since you're the first community contributor it might be good to start doing that. The syntax might be something like xarray's:
- description (:issue:`nn`, ..., :pull:`nn`).
By `Contributor <https://github.com/contributor>`_.
Co-authored-by: keewis <keewis@users.noreply.github.com>
Co-authored-by: keewis <keewis@users.noreply.github.com>
|
Thanks for the review! I have incorporated your suggestions and added a changelog entry. |
|
Great. Thanks again, @mikapfl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to convert all data variables in a Dataset to the same unit by giving a single unit-like instead of a dictionary.
Closes: #45