Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging configuration and workflow #147

Merged
merged 16 commits into from
Jan 8, 2023
Merged

Update packaging configuration and workflow #147

merged 16 commits into from
Jan 8, 2023

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Jan 6, 2023

Description of proposed changes

  • Upload to TestPyPI on push to main
  • Remove setup.py, which is not needed for setuptools>=64.0.0
  • Fix readme syntax
  • Use local_scheme = "node-and-date"

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #147 (6a5094d) into main (463227f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files           6        6           
  Lines         329      329           
  Branches       70       70           
=======================================
  Hits          316      316           
  Misses          8        8           
  Partials        5        5           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@maxrjones
Copy link
Member Author

maxrjones commented Jan 6, 2023

@andersy005 or @norlandrhagen, any ideas why the package version in the "Build and Upload xbatcher to TestPyPI / Publish to Test PyPI" workflow is still {next_version}.dev{distance}+{scm letter}{revision hash}.dYYYYMMDD despite the workflow modifying pyproject.toml to include local_scheme = "no-local-version"? I'm a bit stuck on this.

The issue was keeping setup.py in the repository even though it is no longer needed with setuptools>=64.0.0

@maxrjones maxrjones added the maintenance Maintenance tasks label Jan 7, 2023
@maxrjones maxrjones changed the title Add separate workflow for uploading to TestPyPI Remove setup.py and upload commits to main to TestPyPI Jan 7, 2023
@maxrjones maxrjones changed the title Remove setup.py and upload commits to main to TestPyPI Remove setup.py Jan 7, 2023
@maxrjones maxrjones changed the title Remove setup.py Update packaging configuration and workflow Jan 7, 2023
@maxrjones maxrjones merged commit 553e5ee into main Jan 8, 2023
@maxrjones maxrjones deleted the testpypi branch January 8, 2023 01:07
@maxrjones maxrjones mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants