Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new changelog #141

Merged
merged 11 commits into from
Apr 14, 2024
Merged

docs: new changelog #141

merged 11 commits into from
Apr 14, 2024

Conversation

slevang
Copy link
Collaborator

@slevang slevang commented Dec 18, 2023

Bullet 2/3 on #126. I tried out a few changelog generators and liked this one best. PR is a WIP because I don't know how to make the GH Actions actually play together. As the release job is written here the changelog is generated but lost.

You can install git-cliff locally and run with git cliff -o CHANGELOG.md. Lots of configurable options and we could probably use more filtering, but what I currently have looks like this (for example):

2.2.0 - 2023-11-20

Bug Fixes

Documentation

  • (CHANGELOG) update release notes - (42b5c5e) - Niclas Rieger
  • (changelog) use PAT instead of GITHUB_TOKEN - (fa58532) - Niclas Rieger

Features

Miscellaneous

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (0f95d04) 94.21% compared to head (ccac889) 94.31%.
Report is 52 commits behind head on main.

Files Patch % Lines
xeofs/utils/numba_utils.py 20.96% 49 Missing ⚠️
xeofs/data_container/data_container.py 88.88% 3 Missing ⚠️
xeofs/preprocessing/stacker.py 72.72% 3 Missing ⚠️
xeofs/models/_base_cross_model.py 96.07% 2 Missing ⚠️
xeofs/models/_base_model.py 96.07% 2 Missing ⚠️
xeofs/models/decomposer.py 86.66% 2 Missing ⚠️
xeofs/preprocessing/preprocessor.py 88.88% 2 Missing ⚠️
xeofs/utils/xarray_utils.py 88.88% 2 Missing ⚠️
xeofs/utils/io.py 97.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   94.21%   94.31%   +0.09%     
==========================================
  Files          71       73       +2     
  Lines        5823     6083     +260     
==========================================
+ Hits         5486     5737     +251     
- Misses        337      346       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicrie
Copy link
Collaborator

nicrie commented Dec 18, 2023

that looks really nice, I'll take a look and will play around with it to see whether we can make it work with Github Actions.

PS: sorry got confused about the different PRs and deleted the all_contrbutorsrc file from the wrong PR ;)

@slevang
Copy link
Collaborator Author

slevang commented Apr 14, 2024

Just needed to git add the CHANGELOG. We should probably experiment with the cliff.toml specs a bit more before merging but otherwise this should work now if we like it.

@slevang slevang marked this pull request as ready for review April 14, 2024 14:17
@nicrie
Copy link
Collaborator

nicrie commented Apr 14, 2024

Sorry for the late reply - I’ve been playing around with the cliff.toml file to fine-tune our changelog. Here’s a screenshot of what I think looks good, but it's all pretty subjective, so I’m totally up for changing things up if you have other ideas. Just to summarize:

  1. Ordering of categories: Always start with Features, Performance, Bug fixes, and then the rest.
  2. Added some icons: This should help with visual sorting and make things look a bit more organized.

image

One thing that’s still bugging me is how release messages like release v2.2.0 end up under Miscellaneous. It feels kind of redundant since it just repeats the title. I’d rather skip these commit messages altogether, but that’s just me. I’m cool with whatever you prefer! :)

Copy link
Collaborator Author

@slevang slevang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great to me @nicrie. Feel free to push up your changes. I found and noted the one tweak we need to skip the release commits getting included.

cliff.toml Outdated Show resolved Hide resolved
cliff.toml Outdated Show resolved Hide resolved
nicrie and others added 4 commits April 14, 2024 20:12
Co-authored-by: Sam Levang <39069044+slevang@users.noreply.github.com>
Co-authored-by: Sam Levang <39069044+slevang@users.noreply.github.com>
{ message = "^revert", group = "<!-- 07 -->:rewind: Revert" },
{ message = "^test", group = "<!-- 08 -->:microscope: Tests" },
{ message = "^chore\\(release\\):", skip = true },
{ message = "^chore|ci|build", group = "<!-- 09 -->:gear: Miscellaneous" },
Copy link
Collaborator

@nicrie nicrie Apr 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that we need this pattern here to ignore the release commits

EDIT: sry somehow my vscode got confused - I meant to replace "^chore\\(release\\):" with "^chore: release"

@slevang
Copy link
Collaborator Author

slevang commented Apr 14, 2024

Looks good to me!

@nicrie
Copy link
Collaborator

nicrie commented Apr 14, 2024

Fantastic, thanks @slevang for the initiative - I wait for the CI and then I'll hit the button.

@nicrie nicrie merged commit 35b9ef7 into xarray-contrib:main Apr 14, 2024
6 checks passed
nicrie added a commit that referenced this pull request Apr 14, 2024
In the past, we used two different styles of release commits. PR #141 did only cover one style. Here we add the second style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants