Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: #70 scalar parsing #71

Merged
merged 3 commits into from
Mar 1, 2024
Merged

FIX: #70 scalar parsing #71

merged 3 commits into from
Mar 1, 2024

Conversation

bzah
Copy link
Collaborator

@bzah bzah commented Feb 16, 2024

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

[summarize your pull request here]

Fix #70, scalars attributes are no longer wrapped in tuples.

@bzah bzah requested a review from huard March 1, 2024 09:33
huard
huard approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe highlight in the changes that is a breaking change.

@bzah bzah merged commit 74b35e4 into main Mar 1, 2024
6 checks passed
@bzah bzah deleted the fix/#70_wrapping_tuple branch March 1, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: attributes are wrapped in tuples
2 participants
@bzah @huard