Prepare release 0.1.0 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly, binder seems to use a recent linux OS version, for which the pys2index conda-forge package seems to be broken (seg fault).
Make scipy a required dependency (to have at least one built-in index adapter). Make scikit-learn a required dev dependency (used in tests for computing brute force neighbor lookup).
willirath
approved these changes
Dec 17, 2020
|
I'll just update the doc's index page with the updated description from readme and it should be ready I think. |
|
All right. I'll be unavailable till some time this afternoon. So please don't wait for me and feel free to go ahead merging this and releasing as you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should bring everything needed to cut the 1st release.
Sadly I needed to remove
pys2indexfrom the environment, as it is now also broken on Binder (it still works on RTD). I hope conda-forge linux packages will be somehow fixed soon.@willirath do you see anything else that we should add in README (e.g., funding source / reference to the ESM project?)