Test raise if compute

[ahuang11]

#218

I moved the check for negative values in weights under np apply_ufunc

        # Throw error if there are negative weights.
        if weights.min() < 0:
            raise ValueError(
                "Weights has a minimum below 0. Please submit a weights array "
                "of positive numbers."
            )

[aaronspring]

thats a nice one. could be implemented allover the package

[bradyrx]

If I'm being nit-picky, you should change this to a """ docstring for style.

[bradyrx]

Looks like some trailing whitespace issues from doc8 as well. I think we got rid of doc8 at climpred because it's kind of a nuisance and rst style isn't as important to us.

[aaronspring]

Same here. What’s the status?

[ahuang11]

Not sure what this means

Fix End of Files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing docs/source/api/xskillscore.Contingency.rst

[aaronspring]

Some listing thing. I usually just git add and pre-commit again

[raybellwaves]

Remove this line. Probably git added this by mistake

[raybellwaves]

Think you need to rebase again to pick up #234 for example

[ahuang11]

I don't think so; when I pull and push it says everything up to date...

[raybellwaves]

Sorry for the testing here. Looks like I finally got it on the last one.

Probably still best if you merge my PR ahuang11#1

[ahuang11]

Feel free to do whichever.

[raybellwaves]

I thought I could merge PR in your repo but I can't. I think I can push to the branch though

[raybellwaves]

Thanks @ahuang11