Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use raise_if_dask_computes from xarray #273

Merged
merged 2 commits into from Feb 20, 2021
Merged

use raise_if_dask_computes from xarray #273

merged 2 commits into from Feb 20, 2021

Conversation

raybellwaves
Copy link
Member

Closes #272

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Performance (if you touched existing code run asv to detect performance changes)
  • refactoring

How Has This Been Tested?

Tests still pass

@raybellwaves
Copy link
Member Author

@aaronspring you ok to review? Want to say thanks for @ahuang11 for pointing me to this.

aaronspring
aaronspring approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@aaronspring aaronspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical substitute.

@raybellwaves raybellwaves merged commit 4fcf659 into xarray-contrib:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronspring aaronspring aaronspring approved these changes

@ahuang11 ahuang11 Awaiting requested review from ahuang11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use raise_if_dask_computes from xarray?
2 participants
@raybellwaves @aaronspring