-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Windows #762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xasopheno
added a commit
that referenced
this pull request
Nov 17, 2022
* support for WereSoCool on Windows * update portaudio to use cc * update bumper_cool to bump deps * Update cool_tests and cd to add caching and windows tests * Delete unused files and add platform specific audio files * Update license and readmes * Update settings to check env * Rehash for 48_000
xasopheno
added a commit
that referenced
this pull request
Nov 17, 2022
* support for WereSoCool on Windows * update portaudio to use cc * update bumper_cool to bump deps * Update cool_tests and cd to add caching and windows tests * Delete unused files and add platform specific audio files * Update license and readmes * Update settings to check env * Rehash for 48_000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After @sanxofon created the following issue requesting Windows support:
#759
Once I realized I could get windows running on my mac book with Bootcamp, I decided to try to work on Windows support. Many rabbit holes later, I think I have something that will work.
The WereSoCool on Windoes support does not yes support printing to mp3 or oggvorbis. Both are certainly possible, but I don't yet have enough familiarity with Windows to get them working.
This also updates portaudio quite a bit. The package is now hosted in the repo and uses cc to build and link the dependency.
Also updates settings to respect test environments.
Bumps sample rate to 48_000 on all envs. Hopefully this does not affect performance.