Move settings initialization into OnceCell, Csv2d #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xasopheno
added a commit
that referenced
this pull request
Mar 14, 2023
* do not log imports * update ui * 2d parsing might be ready to try * WIP * csv working...gotta think about it * working on init * new years eve * 1d and 2d csv working * WIP * tests passing * ready to update docs * WIP * hrm maybe no need to track first x in watch? * only create file if needed * readme * improve logging on watch * improve new * csv2d tests passing * cleanup * add back csv1d * demo working * demo working * wip * some lints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates how settings to be initialized with a
OnceCell. This makes room to do things like pass a sample rate, etc to the cli on start without affecting the performance of the rendering engine.Adds Csv2d and (I think) leaves Csv1d working as it did before. They have slightly different implementations. It'll be nice to unify them at some point, but it's not a big deal in the short term. :) I'll take a look at Csv1d again when I get back to rendering MEG's.
Improves the Cli and Readme.
Going to try to release this soon with the record.