Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix primary keys retrieval query #198

Merged
merged 4 commits into from Nov 3, 2023
Merged

Fix primary keys retrieval query #198

merged 4 commits into from Nov 3, 2023

Conversation

exekias
Copy link
Member

@exekias exekias commented Nov 3, 2023 •
edited

The previous query had some issues when used under clusters with many schema objects, this one improves query performance

sorintm
sorintm approved these changes Nov 3, 2023
View reviewed changes
Copy link

@sorintm sorintm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andrew-farries
andrew-farries approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@andrew-farries andrew-farries left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Primary key lookup is checked by the testcases that test backfills, so if the tests pass and it's faster, then ✅

@exekias exekias merged commit 954746b into main Nov 3, 2023
22 checks passed
@exekias exekias deleted the fix-primarykeys-performance branch November 3, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

@sorintm sorintm sorintm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@exekias @andrew-farries @sorintm