Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Complete method signature #231

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

andrew-farries
Copy link
Collaborator

@andrew-farries andrew-farries commented Jan 15, 2024

Change the signature of the Complete method on the Operation interface to take a *schema.Schema argument like the Start and Validate methods already do.

This allows for implementations of Complete to be aware of the entire database schema, supporting things like renaming of any temporary constraints created on columns affected the operation being completed.

See #230, which depends on this PR.

Make `Complete` take a `schema.Schema` so that implementations have
access to the `pgroll`-observed database schema when completing a
migration.
@andrew-farries andrew-farries merged commit 4b124b0 into main Jan 15, 2024
24 checks passed
@andrew-farries andrew-farries deleted the change-complete-method-signature branch January 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants