Preserve column properties on drop constraint operation #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
approved these changes
Jan 26, 2024
exekias
reviewed
Jan 26, 2024
Base automatically changed from
validate-constraint-existence-before-drop
to
main
January 26, 2024 11:47
Allow the column duplictor to be configured to duplicate a column ignoring a particular named constraint.
Dropping a (unique) constraint from a column preserves the default value present on the column.
Dropping a (unique) constraint from a column preserves any foreign key constraints on the column.
Dropping a (unique) constraint from a column preserves any `CHECK` constraints on the column.
Dropping a (check) constraint from a column preserves any `UNIQUE` constraints on the column.
Dropping a (unique) constraint from a column preserves any `NOT NULL` constraints on the column.
Column duplication for all operations is now done by the `RenameDuplicatedColumn` function.
andrew-farries
force-pushed
the
preserve-column-properties-on-drop-constraint
branch
from
78168fe
to
198d008
Compare
andrew-farries
deleted the
preserve-column-properties-on-drop-constraint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that properties of a column are preserved when duplicating a column for backfilling as part of the drop constraint operation.
The properties that are preserved are:
NOT NULLDEFAULTFOREIGN KEYconstraintsCHECKconstraintsUNIQUEconstraintsPart of #227