-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update schema.json
to correctly describe the 'alter column' operation
#261
Conversation
I think we should add some tests around schema validation for the 'alter column' operation here too. |
I pushed another update to the schema - it fixes the problem where |
Describe which fields are required and which are optional.
de5e39c
to
18a1955
Compare
I've added some tests for JSON schema validation in #263 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec also LGTM
Update
schema.json
to correctly describe the 'alter column' operation.The alter column operation is used to perform different alter column operations according to which fields are present.
The rules are:
table
andcolumn
are always required.name
,type
,check
,unique
,references
,nullable
must be present.type
,check
,unique
,references
ornullable
is present, thenup
anddown
must also be present.name
is present then neitherup
ordown
is allowed.This PR updates
schema.json
to capture these dependencies.This change causes churn in the test code as some fields that previously
string
have become*string
.Fixes #222