Update JSON schema to specify that not all Column fields are required
#265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show that not all properties of a column need to be specified.
Show that not all properties of a column need to be specified.
`nullable`, `pk`, and `unique` are optional.
Add methods to column to retrieve nullability, pk and unique now that the underlying fields are optional (pointers).
|
Spec LGTM |
exekias
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the JSON schema in
schema.jsonto state that onlynameandtypeare required fields when specifying a column.Previously
requiredwas set to["name", "nullable", "pk", "type", "unique"]resulting in some validcreate_tableandadd_columnmigrations failing to validate.Add two new testcases to the JSON schema tests to cover 'create_table' and 'add_column' operations.