Strengthen assertions for tests that check preservation of UNIQUE constraints
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not enough to test that the column does not accept duplicate values after the migration completes. Both a unique index and a unique constraint will have that effect but we need to ensure that the **constraint** is present on the table once the migration completes.
exekias
approved these changes
Feb 5, 2024
andrew-farries
added a commit
that referenced
this pull request
Feb 7, 2024
Remove the schema component from index names in the internal schema representation. A `pgroll` migration is always run in the context of a a specific schema so the extra qualification is redundant. Removing the schema component from the index names makes it easy to identify duplicated indexes by name when temporary columns and associated attributes are renamed on migration completion. Tests for this change are already in place (#276, #277). As of this PR, migration tests run in a non-public schema will pass: ```bash PGROLL_TEST_SCHEMA=foo go test ./... ``` Part of #273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strengthen the tests that check for preservation of
UNIQUEconstraints when a column is duplicated so that they can check for the failure case in #273.It's not enough to test that the column does not accept duplicate values after the migration completes. Both a unique index and a unique constraint will have that effect but we need to ensure that the constraint is present on the table once the migration completes.
Duplicating a
UNIQUEconstraint is a two-step process, first creating aUNIQUEindex on migration start and then upgrading the index to a constraint on migration completion. #273 occurs when this upgrade fails and the column is left with the unique index but not the constraint. Subsequent migrations will then fail to duplicate the non-existent unique constraint.Part of #273