Add SQL onComplete flag, allow sql migration to run with others
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by default, SQL migrations run on start. This change allows for special SQL migrations that run only on the complete step.
This reverts commit 24f6822.
| // we don't want to refresh the schema if the operation is not isolated as it would | ||
| // override changes made by other operations | ||
| if refreshOp, ok := op.(migrations.RequiresSchemaRefreshOperation); ok && refreshOp.RequiresSchemaRefresh() { | ||
| if isolatedOp, ok := op.(migrations.IsolatedOperation); ok && isolatedOp.IsIsolated() { |
There was a problem hiding this comment.
Why do we now only refresh schema for ops that are both RequiresSchemaRefreshOperation and IsolatedOperation rather than just RequiresSchemaRefreshOperation?
There was a problem hiding this comment.
Main reason is: that it could be non-isolated & require schema refresh. That's the case for migrations with onComplete.
Migrations that are not isolated & require a schema refresh on Start phase would surely break others, as it would override the resulting schema from the start ops, by refreshing it afterwards. I tried to capture this in the comment
Co-authored-by: Andrew Farries <andyrb@gmail.com>
Co-authored-by: Andrew Farries <andyrb@gmail.com>
Co-authored-by: Andrew Farries <andyrb@gmail.com>
Co-authored-by: Andrew Farries <andyrb@gmail.com>
andrew-farries
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the
sqloperation to:onCompleteflag, that will make it run on the Complete phase, rather than doing it during Start (default behavior).sqloperations next to others in the same migration. We added this limitation to ensure this operation doesn't affect others, especially around schema state management.Having
sqlnext to other operations has proven convenient sometimes, by addingonCompleteflag, we can allow for these migrations to run and rely on views recreation based on the final state.