Fix duplicate inferred migrations when dropping columns outside of a migration #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generalize the test function to allow for multiple SQL statements and multiple expected `inferred` migrations. Add testcases to: * Ensure that dropping a table creates exactly one inferred migration * Ensure that dropping a column creates exactly one inferred migration
exekias
reviewed
Mar 5, 2024
exekias
reviewed
Mar 5, 2024
`ddl_command_end` event triggers also run on `sql_drop` and in most cases contain enough information for the `pgroll.migrations` table to be populated. For example, when a column is dropped from a table, the schema name is available via `pg_catalog.pg_event_trigger_ddl_commands`. Only run `raw_migration` on `sql_drop` for those kinds of drops that do not populate the schema name on `ddl_command_end` to ensure that duplicate entries in the `pgroll.migations` table are not created.
andrew-farries
force-pushed
the
fix-duplicate-drop-column-migrations
branch
from
0f77390
to
801c56f
Compare
exekias
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that only one
inferredmigration is created in thepgroll.migrationstable when a column is dropped outside of a migration.From the Postgres docs:
This means that when the
raw_migrationfunction is run in response tosql_dropandddl_command_end, duplicate entries will be created inpgroll.migrations; once as the function is run forsql_dropand again when it's run forddl_command_end.Change the definition of the
pg_roll_handle_dropevent trigger to only run on those kinds of drops that won't result in duplicates when thepg_roll_handle_ddltrigger runs for the same change.DROP TABLEandDROP VIEWwon't result in duplicate migrations because their schema can't be inferred by theddl_command_eventtrigger because the object has already been dropped when the trigger runs.Update the inferred migration tests with two new testcases covering dropping tables and columns.
Fixes #304