Restrict state connection search path #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict the search path of the connection used by the state package to only the state schema (the schema that containts the `migrations` table). This ensures that any column types that might reside in other schema are always qualified with the schema name in the internal schema representation. Without the restriction of the search path, these type names would be unqualified if they lived in a schema that was on the search path used by the state connection.
exekias
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict the search path of the connection used by the state package to only the state schema (the schema that contains the
migrationstable).This ensures that any column types that might reside in other schema are always qualified with the schema name in the internal schema representation. Without the restriction of the search path, these type names would be unqualified if they lived in a schema that was on the search path used by the state connection.
The representation (qualified/unqualified) of type names in the internal schema is ultimately due to how the format-type function behaves; types in the
search_pathof the caller are unqualified, otherwise they are qualified.