Remove exec flag from tool.py #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tool.py is only intended to be executed through the xattr wrapped generated during package build. Thus tool.py should not have the executable flag set, and should not have a shebang line.
|
I ran into this when packaging xattr for Fedora. In the repository |
etrepum
approved these changes
Oct 24, 2022
|
Thank you! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Oct 28, 2022
Version 0.10.0 released 2022-10-24 * Remove exec flag from tool.py xattr/xattr#106 * Update the documentation to mention the attr package and its getfattr and setfattr tools xattr/xattr#103
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 31, 2022
https://build.opensuse.org/request/show/1032327 by user mcepl + dimstar_suse - Update to 0.10.0 * Remove exec flag from tool.py xattr/xattr#106 * Update the documentation to mention the attr package and its getfattr and setfattr tools xattr/xattr#103
This was referenced Nov 11, 2022
Secrus
added a commit
to python-poetry/poetry
that referenced
this pull request
Nov 11, 2022
# Pull Request Check List Resolves: #6928 <!-- This is just a reminder about the most common mistakes. Please make sure that you tick all *appropriate* boxes. But please read our [contribution guide](https://python-poetry.org/docs/contributing/) at least once, it will save you unnecessary review cycles! --> - [ ] Added **tests** for changed code. - [ ] Updated **documentation** for changed code. <!-- If you have *any* questions to *any* of the points above, just **submit and ask**! This checklist is here to *help* you, not to deter you from contributing! --> Bump `xattr` version to `0.10.0`. This fixes #6891, which is not a problem with the user's environment as suggested by the maintainer of xattr at xattr/xattr#108, but in fact the problem of the package which was fixed by xattr/xattr#106. Looking at the [changes in the version bump](xattr/xattr@v0.9.9...v0.10.0), there does not seem to be any significant changes other than shabang xattr/xattr#106. Co-authored-by: Moonsik Park <moonsik.park@estsoft.com> Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com>
moonsikpark
added a commit
to moonsikpark/poetry
that referenced
this pull request
Nov 15, 2022
update lockfile. pip install --no-input everywhere (python-poetry#6966) This is an extension of python-poetry#6724. I think `pip install` invoked by poetry should never ask for user input. Motivation is that it happened to myself and a number of colleagues many times that poetry got seemingly stuck while it was just waiting for a user input because of a private pypi repository that needed authentication. I hope this is a valuable contribution to a tool I like a lot and would like to use more and more :) docs: update Windows cache path to match 1.2 Bump `xattr` version to `0.10.0`. (python-poetry#7005) Resolves: python-poetry#6928 <!-- This is just a reminder about the most common mistakes. Please make sure that you tick all *appropriate* boxes. But please read our [contribution guide](https://python-poetry.org/docs/contributing/) at least once, it will save you unnecessary review cycles! --> - [ ] Added **tests** for changed code. - [ ] Updated **documentation** for changed code. <!-- If you have *any* questions to *any* of the points above, just **submit and ask**! This checklist is here to *help* you, not to deter you from contributing! --> Bump `xattr` version to `0.10.0`. This fixes python-poetry#6891, which is not a problem with the user's environment as suggested by the maintainer of xattr at xattr/xattr#108, but in fact the problem of the package which was fixed by xattr/xattr#106. Looking at the [changes in the version bump](xattr/xattr@v0.9.9...v0.10.0), there does not seem to be any significant changes other than shabang xattr/xattr#106. Co-authored-by: Moonsik Park <moonsik.park@estsoft.com> Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com> tests: add coverage to `poetry install` update lockfile. [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.2.0 → v3.2.2](asottile/pyupgrade@v3.2.0...v3.2.2) - [github.com/hadialqattan/pycln: v2.1.1 → v2.1.2](hadialqattan/pycln@v2.1.1...v2.1.2)
moonsikpark
added a commit
to moonsikpark/poetry
that referenced
this pull request
Nov 15, 2022
update lockfile. pip install --no-input everywhere (python-poetry#6966) This is an extension of python-poetry#6724. I think `pip install` invoked by poetry should never ask for user input. Motivation is that it happened to myself and a number of colleagues many times that poetry got seemingly stuck while it was just waiting for a user input because of a private pypi repository that needed authentication. I hope this is a valuable contribution to a tool I like a lot and would like to use more and more :) docs: update Windows cache path to match 1.2 Bump `xattr` version to `0.10.0`. (python-poetry#7005) Resolves: python-poetry#6928 <!-- This is just a reminder about the most common mistakes. Please make sure that you tick all *appropriate* boxes. But please read our [contribution guide](https://python-poetry.org/docs/contributing/) at least once, it will save you unnecessary review cycles! --> - [ ] Added **tests** for changed code. - [ ] Updated **documentation** for changed code. <!-- If you have *any* questions to *any* of the points above, just **submit and ask**! This checklist is here to *help* you, not to deter you from contributing! --> Bump `xattr` version to `0.10.0`. This fixes python-poetry#6891, which is not a problem with the user's environment as suggested by the maintainer of xattr at xattr/xattr#108, but in fact the problem of the package which was fixed by xattr/xattr#106. Looking at the [changes in the version bump](xattr/xattr@v0.9.9...v0.10.0), there does not seem to be any significant changes other than shabang xattr/xattr#106. Co-authored-by: Moonsik Park <moonsik.park@estsoft.com> Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com> tests: add coverage to `poetry install` update lockfile. [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.2.0 → v3.2.2](asottile/pyupgrade@v3.2.0...v3.2.2) - [github.com/hadialqattan/pycln: v2.1.1 → v2.1.2](hadialqattan/pycln@v2.1.1...v2.1.2)
moonsikpark
added a commit
to moonsikpark/poetry
that referenced
this pull request
Nov 15, 2022
update lockfile. pip install --no-input everywhere (python-poetry#6966) This is an extension of python-poetry#6724. I think `pip install` invoked by poetry should never ask for user input. Motivation is that it happened to myself and a number of colleagues many times that poetry got seemingly stuck while it was just waiting for a user input because of a private pypi repository that needed authentication. I hope this is a valuable contribution to a tool I like a lot and would like to use more and more :) docs: update Windows cache path to match 1.2 Bump `xattr` version to `0.10.0`. (python-poetry#7005) Resolves: python-poetry#6928 <!-- This is just a reminder about the most common mistakes. Please make sure that you tick all *appropriate* boxes. But please read our [contribution guide](https://python-poetry.org/docs/contributing/) at least once, it will save you unnecessary review cycles! --> - [ ] Added **tests** for changed code. - [ ] Updated **documentation** for changed code. <!-- If you have *any* questions to *any* of the points above, just **submit and ask**! This checklist is here to *help* you, not to deter you from contributing! --> Bump `xattr` version to `0.10.0`. This fixes python-poetry#6891, which is not a problem with the user's environment as suggested by the maintainer of xattr at xattr/xattr#108, but in fact the problem of the package which was fixed by xattr/xattr#106. Looking at the [changes in the version bump](xattr/xattr@v0.9.9...v0.10.0), there does not seem to be any significant changes other than shabang xattr/xattr#106. Co-authored-by: Moonsik Park <moonsik.park@estsoft.com> Co-authored-by: Bartosz Sokorski <b.sokorski@gmail.com> tests: add coverage to `poetry install` update lockfile. [pre-commit.ci] pre-commit autoupdate updates: - [github.com/asottile/pyupgrade: v3.2.0 → v3.2.2](asottile/pyupgrade@v3.2.0...v3.2.2) - [github.com/hadialqattan/pycln: v2.1.1 → v2.1.2](hadialqattan/pycln@v2.1.1...v2.1.2) update lockfile. update lockfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tool.py is only intended to be executed through the xattr wrapped generated during package build.
Thus tool.py should not have the executable flag set, and should not have a shebang line.