-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plplot buildfailure with transition from camlidl 1.05 -> 1.08 #18
Comments
I am able to reproduce this easily:
However I don't understand how it can happen because when I pass the file through cpp myself there is no |
OK I see why this happens. In camlidl the default definition for cpp is:
We don't change this in Fedora. Using the Without
With
We could easily change the Fedora build to remove this flag. However I presume the flag is added for a reason? If we leave the flag in, then plplot would have to change instead. Also I don't want to be different from what Debian & opam are doing as that will introduce unnecessary incompatibility that everyone will need to work around. |
Right, the change of behavior is due to this commit: 13f05c0. I was nervous that running MIDL code (which is not C code) through a standard-conformant C preprocessor could cause errors, so I suggested the Should i just revert the change? Advice welcome. |
The only examples of MSFT idl files I could easily find are from: https://docs.microsoft.com/en-us/windows/win32/com/anatomy-of-an-idl-file That would appear to be an argument to revert the change. |
These are compelling arguments. Reverted in commit e7593d0. Will make a new release ASAP. |
@xavierleroy @rwmjones thanks for handling this so quickly. |
This was fixed in release 1.09 in 2020, closing this issue. |
With the shift from ocaml-camlidl 1.05 -> 1.08 in Fedora rawhide we are getting a build failure in plplot:
This line is:
The macros involved are:
Now, I know nothing about ocaml and camlidl so I'm hoping someone can clue us in on what has changed.
The text was updated successfully, but these errors were encountered: