[BUG] wrong specified states for IKEA 1744?

[liselotte111]

Bug report

Description

My IKEA 1744 did not work. I checked ikea.py and saw "brightness_move_down" in stead of "rotate_left". Same for all the other states. I changed all the states to the ones reported by zigbee2mqtt. But might be easier for others if you changed it?

class E1744MediaPlayerController(MediaPlayerController):
    # Different states reported from the controller:
    # brightness_move_down, brightness_move_up, brightness_stop,
    # toggle, brightness_step_up, brightness_step_down


    def get_z2m_actions_mapping(self) -> TypeActionsMapping:
        return {
            "rotate_left": MediaPlayer.HOLD_VOLUME_DOWN,
            "rotate_right": MediaPlayer.HOLD_VOLUME_UP,
            "rotate_stop": MediaPlayer.RELEASE,
            "play_pause": MediaPlayer.PLAY_PAUSE,
            "skip_forward": MediaPlayer.NEXT_TRACK,
            "skip_backward": MediaPlayer.PREVIOUS_TRACK,
        }

Additional information

• Devices involved:
  • Model: [IKEA 1744 ] as [Media Player]
  • ...
• Integration: mqtt
• AppDaemon version: [v4.0.3 ]
• ControllerX version: [v3.3.0]

AppDaemon app configuration

volumeknop2:
  module: controllerx
  class: E1744MediaPlayerController
  controller: zigbee2mqtt/0xec1bbdfffe8b8e02/action
  integration: mqtt
  media_player: media_player.denon_ceol
  volume_steps: 25
  delay: 150

[xaviml]

Hi @liselotte111

Sorry to hear about this. Which version of Zigbee2MQTT are you currently using? I received a PR (#96) from @fedebruni84 to change the mapping for that controller because it changed in the latest version of Z2M. Maybe @fedebruni84 will know better about this as well.

Thanks,
Xavi M.

[xaviml]

Hi again,

@mvjt confirmed in #103 that the current mapping is correct for the latest stable z2m version. The only thing it was not done was to update the ControllerX documentation for the E1744 device, which I just update and it will be reflected for next release.

[liselotte111]

Hi, Hmm that’s interesting. I’m running the latest zigbee2mqtt version (1.14.2) with mosquitto broker versos 5.1. The E1744 definitely reports volumeup/down/… not brightness in the log file of zigbee2mqtt. As far as I’m aware I’m not running any outdated software

…

On 3 Aug 2020, at 19:54, Xavi Moreno ***@***.***> wrote: Hi again, @mvjt <https://github.com/mvjt> confirmed in #103 <#103> that the current mapping is correct for the latest stable z2m version. The only thing it was not done was to update the ControllerX documentation for the E1744 device, which I just update and it will be reflected for next release. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#105 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI2GJTTNSHXG63L3CMOIMGDR632WJANCNFSM4PMCLNLQ>.

[fedebruni84]

Hi @liselotte111, have you tried to add "legacy: false" to the z2m config?

[liselotte111]

I added that, now indeed it’s brightness_move_up. Thank you for your quick reply!

…

On 3 Aug 2020, at 20:21, fedebruni84 ***@***.***> wrote: Hi @liselotte111 <https://github.com/liselotte111>, have you tried to add "legacy: false" to the z2m config? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#105 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI2GJTR5CIXVWPD7VDRJHVTR635ZXANCNFSM4PMCLNLQ>.

[xaviml]

Hi guys, just to clarify myself and also to document it, if the legacy: false is not in place, then the actions are the old ones (rotate_left, rotate_right, skip_forward, etc). Is this right? If so, I will document this to advice to set legacy: false, which I hope in the future comes by default, this is why is legacy.

Cheers,
Xavi M.

[liselotte111]

Hi, Yes that's correct! Lotte Op wo 5 aug. 2020 om 18:09 schreef Xavi Moreno <notifications@github.com>

…

Hi guys, just to clarify myself and also to document it, if the legacy: false is not in place, then the actions are the old ones (rotate_left, rotate_right, skip_forward, etc). Is this right? If so, I will document this to advice to set legacy: false, which I hope in the future comes by default, this is why is legacy. Cheers, Xavi M. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#105 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI2GJTWWCKZQ7IXTM7CEKATR7F74NANCNFSM4PMCLNLQ> .

[xaviml]

Documentation has been updated with this information: https://xaviml.github.io/controllerx/controllers/E1744