Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ICTCG1Controller/Z2M reporting "brightness" instead of "rotate" #577

Closed
ghiglie opened this issue Sep 22, 2022 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ghiglie
Copy link

ghiglie commented Sep 22, 2022

Bug report

As per title, the IKEA via Z2M integration is reporting with "brighteness" instead of rotate, e.g.: "brightness_move_down"

Additional information

  • Devices involved:
    • Model: IKEA ITTC-G-1 as Controller
    • Model: Yeeligh Mono6 as Light
  • Integration: z2m
  • AppDaemon version: [ v4.2.1 ]
  • ControllerX version: [ v4.23.0 ]
  • HACS version (if installed from there): [ v1.27.2 ]
  • Home Assistant Core version: [ 2022.9.5 ]

AppDaemon app configuration

garage_controller:
  module: controllerx
  class: ICTCG1Controller
  integration: z2m
  controller: remote_dimmer_action
  light: light.yeelight_mono6_0x000000000e366b0a```
@ghiglie ghiglie added the bug Something isn't working label Sep 22, 2022
@xaviml
Copy link
Owner

xaviml commented Sep 25, 2022

Hi @ghiglie ,

Thank you for opening this issue. May I know if you have the legacy: false attribute for this device in Zigbee2mqtt?

Regards,
Xavi M.

@ghiglie
Copy link
Author

ghiglie commented Sep 26, 2022

Hello @xaviml !
You're right, I have the "legacy" parameter set to false (by UI).

I set that on all devices, following the hint on UI - Set to false to disable the legacy integration (highly recommended), will change structure of the published payload (default true)".

I cant' test right now the "true" setting, but it's not a problem keeping it like that.

@xaviml
Copy link
Owner

xaviml commented Sep 26, 2022

Hi @ghiglie ,

No, no need to change that. I have the policy to stick always to the mapping for legacy: false since that is what is recommended from Zigbee2MQTT documentation.

I will change the mapping for this controller.

Regards,
Xavi M.

@xaviml
Copy link
Owner

xaviml commented Sep 26, 2022

Code has been fixed in main branch. It will be ready for next release. In the meantime, you can make it work with the following config:

controller:
  module: controllerx
  class: ICTCG1Controller
  integration: z2m
  controller: remote_dimmer_action
  light: light.yeelight_mono6_0x000000000e366b0a
  mapping:
    brightness_move_up: hold_brightness_up
    brightness_move_down: hold_brightness_down
    brightness_stop: release
    brightness_move_to_level: brightness_from_controller_level

This should work the same way as the fix for now.

Regards,
Xavi M.

@ghiglie
Copy link
Author

ghiglie commented Sep 27, 2022

Thanks Xavi!

@ghiglie ghiglie closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants