Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zha-media-controller): E2002 #531

Merged
merged 5 commits into from
Jul 20, 2022
Merged

feat(zha-media-controller): E2002 #531

merged 5 commits into from
Jul 20, 2022

Conversation

Langthjem
Copy link
Contributor

Adds media player support for IKEA E2001/E2002.
Tested on my own HA installation with latest Controller X installed.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #531 (dcc46fa) into main (da306f9) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head dcc46fa differs from pull request most recent head e1a1169. Consider uploading reports for the commit e1a1169 to get more accurate results

@@         Coverage Diff         @@
##           main   #531   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        59     59           
  Lines      2468   2470    +2     
===================================
+ Hits       2366   2368    +2     
  Misses      102    102           
Impacted Files Coverage Δ
apps/controllerx/cx_devices/ikea.py 92% <100%> (+<1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da306f9...e1a1169. Read the comment docs.

RELEASE_NOTES.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Langthjem Langthjem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes made.

@xaviml xaviml self-requested a review July 20, 2022 13:41
@xaviml xaviml merged commit 17f8c34 into xaviml:main Jul 20, 2022
@xaviml
Copy link
Owner

xaviml commented Jul 20, 2022

Thank you for the PR, code is now merged! It will be ready for next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants