Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary fix to template rendering #811

Merged
merged 1 commit into from Apr 15, 2023
Merged

Conversation

xaviml
Copy link
Owner

@xaviml xaviml commented Apr 15, 2023

This PR fixes an AppDaemon 4.4.0 and 4.4.1 bug:

AppDaemon/appdaemon#1747

It seems that the problem has been fixed (AppDaemon/appdaemon#1750),
but it is not known when the fix will be released.

This entire file can be deleted once the fix is in place officially from AppDaemon.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2023

@github-actions github-actions bot temporarily deployed to pull request April 15, 2023 19:01 Inactive
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Patch coverage: 50% and no project coverage change.

Comparison is base (20c22cc) 96% compared to head (fe22363) 96%.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #811   +/-   ##
===================================
- Coverage    96%    96%   -0%     
===================================
  Files        65     65           
  Lines      2663   2667    +4     
===================================
+ Hits       2548   2550    +2     
- Misses      115    117    +2     
Impacted Files Coverage Δ
apps/controllerx/cx_core/controller.py 95% <50%> (-1%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot temporarily deployed to pull request April 15, 2023 19:04 Inactive
@xaviml xaviml merged commit 9c69033 into main Apr 15, 2023
13 checks passed
@xaviml xaviml deleted the fix/template-rendering branch April 15, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant