-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
God-mode teleport for regtest testing #8
Comments
domob1812
added a commit
that referenced
this issue
Mar 26, 2019
Add processing of admin commands. With them, we allow "god mode" teleports of characters ON REGTEST. This will be very useful for simpler, more robust and more efficient integration testing. God-mode is protected twofold against abuse: First, it is only accessible through admin commands. That means that only the owner of g/tn (Xaya team) can issue those in the first place. And second, handling of god mode specifically is factored into its own function with an explicit check for regtest right at the start. This implements #8.
domob1812
added a commit
that referenced
this issue
Mar 26, 2019
Add processing of admin commands. With them, we allow "god mode" teleports of characters ON REGTEST. This will be very useful for simpler, more robust and more efficient integration testing. God-mode is protected twofold against abuse: First, it is only accessible through admin commands. That means that only the owner of g/tn (Xaya team) can issue those in the first place. And second, handling of god mode specifically is factored into its own function with an explicit check for regtest right at the start. This implements #8.
domob1812
added a commit
that referenced
this issue
Mar 26, 2019
Add processing of admin commands. With them, we allow "god mode" teleports of characters ON REGTEST. This will be very useful for simpler, more robust and more efficient integration testing. God-mode is protected twofold against abuse: First, it is only accessible through admin commands. That means that only the owner of g/tn (Xaya team) can issue those in the first place. And second, handling of god mode specifically is factored into its own function with an explicit check for regtest right at the start. This implements #8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For easier set up of testing scenarios, we should implement a "god mode" that allows character teleports in regtest mode only. This would be admin commands (so only someone controlling
g/tn
can do it as an additional layer of protection), and only be interpreted on regtest mode.With that, we can greatly simplify and speed up the
moveCharactersTo
Python function for integration tests and make it less flaky.The text was updated successfully, but these errors were encountered: