-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong URL created for image in map - wrong category used #74
Comments
More info: This seems to happen because I have a category with this name twice in piwigo: one from uploading and one from converting to virtual later on. |
Getting closer... In functions_map.php the query is using "i.storage_category_id" to create the imageurl to be used as link in the popup:
And that gives another result as the link that is used for the list of thumbs below the map! |
Which lead to this quick-hack to use the category of the page if set:
|
Well above is only a quick-hack that works in some cases. Root cause of the issue is that i.storage_category_id isn't OK to use since it might be in the list of categories returned by get_sql_condition_FandF! |
And here is the solution to use the INNER JOIN result: Use ic.category_id instead of i.storage_category_id as category for creating the imgurl |
i.storage_category_id might be in the list of $forbidden categories, use ic.category_id instead
Pull request created for fix |
Your welcome |
# Conflicts: # include/functions_map.php
It seems like this issue got "re-introduced" - at least I had the problem in 2.8a and was able to fix it by changing the relevant line in functions_map.php |
Hi,
when looking at an album on my site (e.g. http://www.feuster.com/piwigo/index.php?/category/651) and clicking on a marker in the map to show a thumb I can see that the link created is incorrect:
http://www.feuster.com/piwigo/picture.php?/6675/category/630
where it should be
http://www.feuster.com/piwigo/picture.php?/6675/category/651
Note, that in the map the incorrect category is used in the link! A quick scan indicates that this happens in all albums.
In idea how to fix this?
Thanks,
Thomas
The text was updated successfully, but these errors were encountered: