-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected Products in latest myget Geometry causing crashes #26
Comments
Hi, On 29 Jul 2015, at 23:24, Andy Ward notifications@github.com wrote: @martin1cerny https://github.com/martin1cerny , just a heads up, this may It looks like there's been a change in how we're handling openings in the Repro Using Xbim.Geometry 3.1.3 from Myget/develop, and the latest XbimWebUI Take any Model with an opening(e.g. OneWallTwoWindows.ifc) and you'll get If you use a wexbim generated from the latest Nuget Xbim.Geometry it's I'll see if I can track it back to a particular change but it may be a few [image: image] Left is latest Geometry (Myget 3.1.3). Right is the old Geometry (Nuget Loading the new (and old) xbim files into XbimXplorer renders OK Sounds like either:
— |
@CBenghi Did you get any further with this? Still seeing the issue with latest develop code. |
@andyward I'm sorry I didn't catch on this before. Thanks for the heads up. But it seems it is a bug in XbimGeometry or XbimIO rather than in WeXplorer. It just indicates that the wexbim file is wrong which is apparently true. I also wonder if @CBenghi got any further. P.S.: It is interesting that most issues raised on GitHub in XbimWebUI project are related to different parts of xBIM :-) |
I did a bit a investigation into this. There are actually two issues.
So after resolving the first issue you get: Using OneWallTwoWindows.ifc as a test case I added some diagnostics using Geometry 3.0.23 and the latest Develop. We have the same 3 products (1 Wall and 2 Windows), but three extra shapes (# 5-7). Shape 6 is the uncut wall, while 5&7 are the openings with no product reference. Hope that helps you @CBenghi Andy |
Hi Andy, |
Hi Andy, |
Hi Claudio Thanks On 29 August 2015 at 14:31, Claudio Benghi notifications@github.com wrote:
|
Hi Darren, |
@CBenghi Nice work! Looks to have fixed the issue 👍 Note for anyone else - I used 3.1.10-V00006 I guess we need to discuss if we ever want these geometries in a wexbim at some point. My gut feel is to wait until we find a need since we want to keep the wexbim payload a light as possible. |
Closing |
@martin1cerny , just a heads up, this may be one for you or it may be one for @CBenghi
It looks like there's been a change in how we're handling openings in the Geometry Engine (possibly this change: xBimTeam/XbimGeometry@e63ad95) - which is causing the xbim-viewer[...].js to throw an exception during parsing of the wexbim file.
Repro
Using Xbim.Geometry 3.1.3 from Myget/develop, and the latest XbimWebUI (pre-release from myget)
Take any Model with an opening(e.g. OneWallTwoWindows.ifc) and you'll get error on the console at this line:
https://github.com/xBimTeam/XbimWebUI/blob/master/Xbim.WeXplorer/Viewer/xbim-model-geometry.debug.js#L175
If you use a wexbim generated from the latest Nuget Xbim.Geometry it's fine.
I'll see if I can track it back to a particular change but it may be a few days before I can look at it. I put a spot fix in to skip the problem items and you see something like this:
Left is latest Geometry (Myget 3.1.3). Right is the old Geometry (Nuget 3.0.21). Both are the same source model file and XbimWebUI code. The only difference is the version of Xbim.Geometry used to generate the webxbim. Might be worth speaking to Claudio to see what the intention is with the above change. The newer wexbim is larger so I'm assuming it contains extra records (intentionally, or unintentionally).
Loading the new (and old) xbim files into XbimXplorer renders OK
Sounds like either:
or
The text was updated successfully, but these errors were encountered: