Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] [german] Download dialog is ambigous (and one mis-spelled word) #435

Closed
DamageIncorporated opened this issue Aug 30, 2017 · 3 comments

Comments

@DamageIncorporated
Copy link
Contributor

Hey there,

I hope this is the correct spot to drop translation bugs but I don't have a forum account and you may be able to forward this to the german translator from here:

How to reproduce:

  • Use Kore in german localization
  • Select Music(Musik) -> Artists(Künstler) -> [Artist Name]
  • Hit the download button

If there are multiple files to download, you get the question shown in the screenshot:

screenshot_20170830-091502

The first sentence in german now says something like "Do you want to download (single) song (numbered) 37?"

actual phrase (wrong):
Wollen sie das Lied ## herunterladen?

new phrase (correct):
Wollen Sie ## Lieder herunterladen?

A minor bug is the word "Hintergrung" in the following sentence:

actual word (wrong):
Hintergrung

new word (correct):
Hintergrund

I would happily write the correct string myself but would need assistance on how to do that.
I am not a developer and don't know my ways around git (github) except for filing a bug report here and there.
If someone is willing to show me the file that needs to be edited and how to give it back to the project afterwards, I would be very happy to help and do the fix myself

Greetings from Beckum, Germany, Earth

Markus

@poisdeux
Copy link
Member

Hello Markus,

The file that holds the translations for German is
https://github.com/xbmc/Kore/blob/master/app/src/main/res/values-de/strings.xml

The actual line that contains the translation for above message is
https://github.com/xbmc/Kore/blob/master/app/src/main/res/values-de/strings.xml#L276

Would be nice if you could fix it.

@DamageIncorporated
Copy link
Contributor Author

Hmm... I think that was my first pull request ever :-)

SyncedSynapse pushed a commit that referenced this issue Sep 2, 2017
Correction as in issue #435 and aligned wording to similar strings in lines 272ff
@SyncedSynapse
Copy link
Member

Congrats.

Unfortunately, we've just sent a new release for beta test yesterday, so this will only be fixed in the release after that...

If you want it now, you can get the nightly build at mirrors.kodi.tv (tomorrow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants