Removed dependency on GridLayout in SquareGridLayout #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed using the GridLayout from the support library
as this might be causing problems on devices that don't
include the library correctly.
* Replaced using the GridLayout measurement and layout implementations
by our own implementation of a simple grid layout that will evenly distribute
its children among a square sized grid.
SyncedSynapse
added a commit
that referenced
this pull request
Sep 15, 2017
This reverts commit 876db18.
SyncedSynapse
added a commit
that referenced
this pull request
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes the heisenbug we encountered during the beta release as mentioned in #444
as this might be causing problems on devices that don't
include the library correctly.
by our own implementation of a simple grid layout that will evenly distribute
its children among a square sized grid.