Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kodi settings controller to dynamically adapt its layout #509

Open
wutschel opened this issue Dec 3, 2021 · 0 comments · May be fixed by #1087
Open

Kodi settings controller to dynamically adapt its layout #509

wutschel opened this issue Dec 3, 2021 · 0 comments · May be fixed by #1087

Comments

@wutschel
Copy link
Collaborator

wutschel commented Dec 3, 2021

The controller SettingsValuesViewController implements the Kodi settings menu. The controller reads the available settings from Kodi and displays labels, texts and UI elements like radio buttons or sliders. The controller hardcodes the layout using various magic numbers. In b085388 there was already an -- also hardcoded -- fix added to show the complete text of a very long settings description. In consequence there is now far too much space given for other settings.

A rework of this controller is desired to let the UI element's positions and label dimensions follow the setting's text and needs dynamically. This will also make it future proof for any changes in Kodi setting's descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant