Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Use 'long' instead of 'int' when dealing with database IDs #570

Open
wutschel opened this issue Jan 19, 2022 · 1 comment
Open

Maintenance: Use 'long' instead of 'int' when dealing with database IDs #570

wutschel opened this issue Jan 19, 2022 · 1 comment
Labels
maintenance

Comments

@wutschel
Copy link
Collaborator

The App uses int type variables when handling Kodi database IDs. This covers a huge amount of IDs, but to make this more robust and future-proof this should be changed to use of long type as Kodi provides via the JSON API.

Example: [item[@"recordingid"] intValue] > 0 would become [item[@"recordingid"] longValue] > 0
@wutschel wutschel mentioned this issue Feb 10, 2022
Merged
@wutschel
Copy link
Collaborator Author

In NowPlaying controller there is still some rework needed to read IDs as long type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wutschel