Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote tries to connect to Kodi after executing Quit Application #633

Open
kambala-decapitator opened this issue Mar 17, 2022 · 5 comments

Comments

@kambala-decapitator
Copy link
Collaborator

this should be prevented. Also for Power off, Hibernate and Suspend. In Reboot case I think it can stay.

@wutschel
Copy link
Collaborator

I understand the motivation behind this, but Imam not quite sure how the behaviour should be.

For example the App could in such case deselect the active server? This would stop searching, but it would be persistent. So, after restart of the App it will not re-connect automatically again and the user needs to explicitly select the server. Not sure if this is desired after a user triggered shutdown, quit or hibernate.

@kambala-decapitator
Copy link
Collaborator Author

Yes, basically just disconnect after action execution succeeds.

We can make it configurable via switch in settings with default = false to retain existing behavior.

@wutschel
Copy link
Collaborator

Ok, I will look into this. But not for 1.10 -- I don't want to add unnecessary risk now.

@kambala-decapitator
Copy link
Collaborator Author

that's for sure :)

@wutschel
Copy link
Collaborator

I did a first proof of concept change which already works basically. But I don't like the overall logic yet.

On server shutdown, quit application:
The app will assume the server is down, mark connection "red" and stop pulling. For system reboot I would keep the behaviour as it is -- it will try to reconnect until server is back.

App state:

  • Server still marked as selected, but with "red" connection state
  • Reconnect by user via deselect / select the server (2 tips)
  • After App suspend / wakeup reconnect by user via deselect / select the server (2 tips)
  • After App restart reconnect automatically to the same server

I am not convinced yet by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants