Skip to content

Commit

Permalink
Add check for print statement
Browse files Browse the repository at this point in the history
  • Loading branch information
mzfr authored and mzfr committed Sep 20, 2020
1 parent dade408 commit e187c8e
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 0 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ It can also be used locally for detecting problems in your addons.

- Check if all PO files are valid

- Check if there exists any print statement in the addon.

All of the validation and checks are done according to the kodi [addon rules](https://kodi.wiki/view/Add-on_rules)

## Installation
Expand Down
2 changes: 2 additions & 0 deletions kodi_addon_checker/check_addon.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ def start(addon_path, args, all_repo_addons, config=None):

check_py3_compatibility.check_py3_compatibility(addon_report, addon_path, KodiVersion(args.branch))

check_files.check_print_statement(addon_report, file_index)

if config.is_enabled("check_license_file_exists"):
# check if license file is existing
handle_files.addon_file_exists(addon_report, addon_path,
Expand Down
29 changes: 29 additions & 0 deletions kodi_addon_checker/check_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
See LICENSES/README.md for more information.
"""

import ast
import json
import os
import re
Expand Down Expand Up @@ -148,3 +149,31 @@ def check_file_permission(report: Report, file_index: list):
file = os.path.join(file["path"], file["name"])
if os.path.isfile(file) and os.access(str(file), os.X_OK):
report.add(Record(PROBLEM, "%s is marked as stand-alone executable" % relative_path(str(file))))


def check_print_statement(report: Report, file_index: list):
"""Check whether any addon files have a print statement in them
or not
:file_index: list having names and path of all the files present in addon
"""
for file in file_index:
if os.path.splitext(file["name"])[1] == '.py':
file = os.path.join(file["path"], file["name"])
try:
with open(file, 'r', encoding="utf-8") as f:
source = f.read()

try:
for node in ast.walk(ast.parse(source)):
if (isinstance(node, ast.Expr) and
isinstance(node.value, ast.Call) and
isinstance(node.value.func, ast.Name)):

if node.value.func.id == "print":
report.add(Record(WARNING, "%s has a print statement on line %s" %
(relative_path(str(file)), node.lineno)))
except SyntaxError as e:
report.add(Record(PROBLEM, "%s failed to parse with %s" % (relative_path(str(file)), e)))

except UnicodeDecodeError as e:
report.add(Record(PROBLEM, "UnicodeDecodeError: {}".format(e)))

0 comments on commit e187c8e

Please sign in to comment.